John Beck wrote:
> I reviewed the changes for NWAM, SMF, install/bfu/upgrade and other.
> The work looks to be very well done, as I only found one issue where
> a change in the net-physical start method appears to be needed in
> the net-nwam method as well, plus some nits in bfu.sh:
>
Thanks for your quick comments!
> * cmd/svc/milestone/net-physical
>
> Isn't the purge-phys change also needed in net-nwam?
>
ACCEPT
But since up-aggr is not in net-nwam (I remembered I asked this question
before, and the answer is NWAM does not support aggr right now).
I would assume that NWAM will not support VLAN either, and I didn't add
up-vlan in the net-nwam script.
> * tools/scripts/bfu.sh
>
> * 632: typo: s/admnistrator/administrator/
ACCEPT.
> * 657: typo: extra #
ACCEPT.
> * 659: should this be "((i = i + 1))"?
It seems both are fine. I will make changes as you suggested though.
> * 649,658,660,663,685: unnecessary use of {}
ACCEPT.
> * 1963-1973: this should not be necessary, as Nevada bfu is supposed
> to assume a baseline of S10 FCS which includes SMF
>
You mean 1969-1973, right? As I understand, 1963-1967 is used to support
alternative root BFU.
Thanks
- Cathy
> -- John
>
> http://blogs.sun.com/jbeck
>
> _________________________________
> clearview-discuss mailing list
> clearview-discuss at opensolaris.org