It's 3 am in BEIJING now...
See the text below.
Roland Mainz Wrote:
> Cathy Zhou wrote:
>
>>John Beck wrote:
>>
>>>I reviewed the changes for NWAM, SMF, install/bfu/upgrade and other.
>>>The work looks to be very well done, as I only found one issue where
>>>a change in the net-physical start method appears to be needed in
>>>the net-nwam method as well, plus some nits in bfu.sh:
>
> [snip]
>
> Erm... it seems I never got the initial email with the webrev URL...
> where can I find it ?
>
> ----
>
> Bye,
> Roland
>
Hi,
We'd like each of you to participate in the code review of the Clearview UV
component. The changes are major, and we've divided them into different
portions and identified each of you as potential candidate to review
specific portion. If any of you is unable to review the code, please let us
know as soon as possible, and please also let me know who you think would be
a good alternative reviewer.
The timeout is set as two weeks.
Of course, anyone else who is interested is welcome to take a look of the
webrev, and your comments are very much appreciated!
Thanks!
- Cathy
NWAM: Renee, Michael Hunter
WIFI and WPA: Quaker Fang, Judy Chen, Cecilia Hu
IP instance: Donghai, Erik Nordmark
LDoms: Narayan, Sriharsha
softmac: Garrett, Thirumalai, Seb
GLD: Eric Cheng, Kais, Nicolas, Seb
TCP/IP: Thirumalai, Rajagopal, Kacheong
libdlpi: Sagun, Seb
RCM: Meem
devname: Jerry Gilliam
xVM: dme,
dladm/libdladm: Sowmini, Seb
aggr: Nicolas, Seb
SMF: Seb, David Powell
dlmgmtd and dlmgmt API: Artem, Seb
install/bfu/upgrade: Seb, John Beck
External webrev:
http://cr.grommit.com/~yun/webrev_uv_09_28
Internal webrev:
http://jurassic.sfbay/net/forwar.prc/builds/yz147064/clearview-uv-review/webrev_review/
Cscope:
/net/forwar.prc/builds/yz147064/clearview-uv-review/
Also, a file list is attached to show each review portions.
NWAM related changes:
---------------------
usr/src/cmd/cmd-inet/lib/nwamd/functions.h
usr/src/cmd/cmd-inet/lib/nwamd/interface.c
usr/src/cmd/cmd-inet/lib/nwamd/structures.h
usr/src/cmd/cmd-inet/lib/nwamd/wireless.c
WIFI and WPA related changes:
-----------------------------
usr/src/cmd/cmd-inet/usr.lib/wpad/driver.h
usr/src/cmd/cmd-inet/usr.lib/wpad/driver_wifi.c
usr/src/cmd/cmd-inet/usr.lib/wpad/wpa.c
usr/src/cmd/cmd-inet/usr.lib/wpad/wpa_impl.h
usr/src/cmd/cmd-inet/usr.lib/wpad/wpa_supplicant.c
usr/src/lib/libdladm/common/libdlwlan.c
usr/src/lib/libdladm/common/libdlwlan.h
usr/src/lib/libdladm/common/libdlwlan_impl.h
usr/src/lib/libdladm/common/linkprop.c
usr/src/lib/libdladm/common/secobj.c
IP instance related changes:
-----------------------------
usr/src/lib/libdladm/common/linkprop.c
usr/src/cmd/zoneadmd/vplat.c
usr/src/lib/libdladm/common/libdllink.c
usr/src/lib/libdladm/common/libdllink.h
usr/src/uts/common/sys/dld.h
usr/src/cmd/truss/codes.c
usr/src/uts/common/io/dld/dld_drv.c
usr/src/uts/common/io/dls/dls_vlan.c
usr/src/uts/common/sys/zone.h
usr/src/uts/common/os/zone.c
libdlpi related changes:
-----------------------------
usr/src/lib/libdlpi/Makefile.com
usr/src/lib/libdlpi/common/libdlpi.c
usr/src/lib/libdlpi/common/libdlpi.h
usr/src/lib/libdlpi/common/mapfile-vers
usr/src/lib/libinetcfg/Makefile.com
usr/src/lib/libinetcfg/common/inetcfg.c
usr/src/cmd/cmd-inet/usr.sbin/ifconfig/Makefile
usr/src/cmd/cmd-inet/usr.sbin/ifconfig/defs.h
usr/src/cmd/cmd-inet/usr.sbin/ifconfig/ifconfig.c
usr/src/lib/libuuid/Makefile.com
usr/src/lib/libuuid/common/etheraddr.c
usr/src/lib/Makefile
LDoms related changes:
---------------------
usr/src/uts/sun4v/io/vnet.c
usr/src/uts/sun4v/io/vnet_gen.c
usr/src/uts/sun4v/io/vsw.c
usr/src/uts/sun4v/sys/vsw.h
usr/src/uts/sun4v/vsw/Makefile
RCM related changes:
---------------------
usr/src/cmd/rcm_daemon/Makefile.com
usr/src/cmd/rcm_daemon/common/aggr_rcm.c
usr/src/cmd/rcm_daemon/common/ip_rcm.c
usr/src/cmd/rcm_daemon/common/network_rcm.c
usr/src/cmd/rcm_daemon/common/vlan_rcm.c
usr/src/lib/librcm/librcm.h
usr/src/lib/librcm/Makefile.com
usr/src/pkgdefs/SUNWcsu/prototype_com
devname related changes:
------------------------
usr/src/uts/sparc/dev/Makefile
usr/src/uts/intel/dev/Makefile
usr/src/uts/common/fs/dev/sdev_netops.c
usr/src/uts/common/fs/dev/sdev_subr.c
usr/src/uts/common/fs/dev/sdev_vnops.c
usr/src/uts/common/sys/fs/sdev_impl.h
usr/src/pkgdefs/SUNWcsd/prototype_com
NIC driver changes:
--------------------
usr/closed/uts/common/io/ixgb/ixgb_gld.c
usr/closed/uts/common/io/nge/nge_main.c
usr/closed/uts/common/io/rtls/rtls.c
usr/closed/uts/intel/io/iprb/iprb.c
usr/src/uts/sun/io/eri.c
usr/src/uts/sun/io/hme.c
usr/src/uts/sun4u/io/dmfe/dmfe_main.c
usr/src/uts/common/io/afe/afe.c
usr/src/uts/common/io/e1000g/e1000g_main.c
usr/src/uts/common/io/nxge/nxge_main.c
usr/src/uts/common/io/rge/rge_main.c
usr/src/uts/common/io/bge/bge_main2.c
usr/src/uts/common/io/mxfe/mxfe.c
usr/src/uts/common/io/xge/drv/xgell.c
softmac changes:
-----------------
usr/src/uts/common/io/net_dacf.c
usr/src/uts/common/io/softmac/softmac.conf
usr/src/uts/common/io/softmac/softmac_capab.c
usr/src/uts/common/io/softmac/softmac_ctl.c
usr/src/uts/common/io/softmac/softmac_dev.c
usr/src/uts/common/io/softmac/softmac_main.c
usr/src/uts/common/io/softmac/softmac_pkt.c
usr/src/uts/common/io/softmac/softmac_stat.c
usr/src/uts/common/os/dacf.c
usr/src/uts/common/os/dacf_clnt.c
usr/src/uts/common/os/sunddi.c
usr/src/uts/common/sys/dacf.h
usr/src/uts/intel/os/dacf.conf
usr/src/uts/intel/os/device_policy
usr/src/uts/sparc/net_dacf/Makefile
usr/src/uts/sparc/os/dacf.conf
usr/src/uts/sparc/os/device_policy
usr/src/uts/sparc/os/name_to_major
usr/src/uts/sparc/softmac/Makefile
usr/src/uts/common/sys/softmac.h
usr/src/uts/common/sys/softmac_impl.h
usr/src/uts/common/sys/sunddi.h
usr/src/uts/intel/net_dacf/Makefile
usr/src/uts/intel/os/name_to_major
usr/src/uts/intel/softmac/Makefile
usr/src/pkgdefs/SUNWckr/prototype_com
usr/src/pkgdefs/SUNWckr/prototype_i386
usr/src/pkgdefs/SUNWckr/prototype_sparc
usr/src/pkgdefs/common_files/i.minorperm_i386
usr/src/pkgdefs/common_files/i.minorperm_sparc
usr/src/uts/common/Makefile.rules
usr/src/uts/common/Makefile.files
xVM related changes
-------------------------------
usr/src/cmd/vna/vna.c
usr/src/lib/libdladm/common/libdlvnic.c
usr/src/lib/libdladm/common/libdlvnic.h
usr/src/uts/intel/vnic/Makefile
usr/src/uts/sparc/vnic/Makefile
usr/src/uts/common/sys/vnic.h
usr/src/uts/common/sys/vnic_impl.h
usr/src/uts/common/xen/io/xnbo.c
usr/src/uts/i86xpv/xnbo/Makefile
usr/src/uts/common/io/vnic/vnic_ctl.c
usr/src/uts/common/io/vnic/vnic_dev.c
dladm/libdladm changes
----------------------
usr/src/cmd/dladm/Makefile
usr/src/cmd/dladm/dladm.c
usr/src/cmd/dladm/dladm.xcl
usr/src/lib/libdladm/Makefile
usr/src/lib/libdladm/Makefile.com
usr/src/lib/libdladm/common/libdladm.c
usr/src/lib/libdladm/common/libdladm.h
usr/src/lib/libdladm/common/libdlaggr.c
usr/src/lib/libdladm/common/libdlaggr.h
usr/src/lib/libdladm/common/libdllink.c
usr/src/lib/libdladm/common/libdllink.h
usr/src/lib/libdladm/common/libdlmgmt.c
usr/src/lib/libdladm/common/libdlmgmt.h
usr/src/lib/libdladm/common/libdlvlan.c
usr/src/lib/libdladm/common/libdlvlan.h
usr/src/lib/libdladm/common/libdlwlan.c
usr/src/lib/libdladm/common/libdlwlan.h
usr/src/lib/libdladm/common/libdlwlan_impl.h
usr/src/lib/libdladm/common/linkprop.c
usr/src/lib/libdladm/common/llib-ldladm
usr/src/lib/libdladm/common/mapfile-vers
usr/src/lib/libdladm/common/linkprop.c
usr/src/lib/libdladm/common/secobj.c
usr/src/cmd/cmd-inet/usr.bin/netstat/netstat.c
the aggr driver changes
----------------------------
usr/src/uts/common/io/aggr/aggr_ctl.c
usr/src/uts/common/io/aggr/aggr_dev.c
usr/src/uts/common/io/aggr/aggr_grp.c
usr/src/uts/common/io/aggr/aggr_lacp.c
usr/src/uts/common/io/aggr/aggr_port.c
usr/src/uts/common/io/aggr/aggr_recv.c
dlmgmtd and data-link management API
-----------------------------------
usr/src/cmd/dlmgmtd/Makefile
usr/src/cmd/dlmgmtd/datalink.conf
usr/src/cmd/dlmgmtd/dlmgmt.xml
usr/src/cmd/dlmgmtd/dlmgmt_db.c
usr/src/cmd/dlmgmtd/dlmgmt_door.c
usr/src/cmd/dlmgmtd/dlmgmt_impl.h
usr/src/cmd/dlmgmtd/dlmgmt_main.c
usr/src/cmd/dlmgmtd/dlmgmt_util.c
usr/src/cmd/dlmgmtd/svc-dlmgmtd
usr/src/uts/common/io/dls/dls_mgmt.c
usr/src/lib/libdladm/common/libdlmgmt.c
usr/src/pkgdefs/SUNWcsr/prototype_com
usr/src/cmd/Makefile
usr/src/Makefile.lint
SMF changes
-----------
usr/src/cmd/svc/milestone/net-physical
usr/src/lib/brand/native/zone/platform.xml
usr/src/lib/brand/sn1/zone/platform.xml
usr/src/cmd/svc/seed/Makefile
usr/src/cmd/svc/seed/inc.flg
usr/src/tools/scripts/bfu.sh
TCP/IP changes:
------------
usr/src/uts/common/inet/ip.h
usr/src/uts/common/inet/ip/ip_if.c
usr/src/uts/common/inet/ip/ip_squeue.c
usr/src/uts/common/inet/tcp/tcp.c
GLD changes
------------------------------
usr/src/uts/common/io/dld/dld_drv.c
usr/src/uts/common/io/dld/dld_proto.c
usr/src/uts/common/io/dld/dld_str.c
usr/src/uts/common/io/dls/dls.c
usr/src/uts/common/io/dls/dls_link.c
usr/src/uts/common/io/dls/dls_mgmt.c
usr/src/uts/common/io/dls/dls_mod.c
usr/src/uts/common/io/dls/dls_soft_ring.c
usr/src/uts/common/io/dls/dls_stat.c
usr/src/uts/common/io/dls/dls_vlan.c
usr/src/uts/common/io/mac/mac.c
usr/src/uts/common/io/mac/mac_stat.c
usr/src/uts/common/sys/Makefile
usr/src/uts/common/sys/aggr.h
usr/src/uts/common/sys/aggr_impl.h
usr/src/uts/common/sys/dld.h
usr/src/uts/common/sys/dld_impl.h
usr/src/uts/common/sys/dlpi.h
usr/src/uts/common/sys/dls.h
usr/src/uts/common/sys/dls_impl.h
usr/src/uts/common/sys/dls_soft_ring.h
usr/src/uts/common/sys/gld.h
usr/src/uts/common/sys/mac.h
usr/src/uts/common/sys/mac_impl.h
usr/src/uts/intel/Makefile.intel.shared
usr/src/uts/intel/aggr/Makefile
usr/src/uts/intel/ia32/ml/modstubs.s
usr/src/uts/intel/strplumb/Makefile
usr/src/uts/sparc/Makefile.sparc.shared
usr/src/uts/sparc/aggr/Makefile
usr/src/uts/sparc/ml/modstubs.s
usr/src/uts/common/io/gld.c
usr/src/uts/common/io/strplumb.c
usr/src/uts/common/os/streamio.c
usr/src/cmd/truss/codes.c
usr/src/uts/common/Makefile.files
install, bfu and system upgrade
-------------------------------
usr/src/uts/common/os/swapgeneric.c
usr/src/tools/scripts/bfu.sh
usr/src/pkgdefs/SUNWcnetr/postinstall
usr/src/tools/abi/etc/ABI_i386.db
usr/src/tools/abi/etc/ABI_sparc.db
usr/src/tools/abi/etc/exceptions
usr/src/Targetdirs
usr/src/cmd/devfsadm/devfsadm.c
usr/src/lib/cfgadm_plugins/sbd/common/ap_rcm.c
usr/src/lib/cfgadm_plugins/sbd/sbd.xcl
usr/src/pkgdefs/SUNWarc/prototype_com
usr/src/pkgdefs/SUNWarc/prototype_i386
usr/src/pkgdefs/SUNWarc/prototype_sparc
usr/src/pkgdefs/SUNWarcr/prototype_com
usr/src/pkgdefs/SUNWarcr/prototype_i386
usr/src/pkgdefs/SUNWarcr/prototype_sparc
usr/src/pkgdefs/SUNWcnetr/prototype_com
usr/src/pkgdefs/SUNWcsl/prototype_com
usr/src/pkgdefs/SUNWcsl/prototype_i386
usr/src/pkgdefs/SUNWcsl/prototype_sparc
usr/src/pkgdefs/SUNWcslr/prototype_com
usr/src/pkgdefs/SUNWcslr/prototype_i386
usr/src/pkgdefs/SUNWcslr/prototype_sparc
Others
----------------------------------
usr/src/Targetdirs
usr/src/pkgdefs/etc/exception_list_i386
usr/src/pkgdefs/etc/exception_list_sparc
