Cathy Zhou wrote: > install/bfu/upgrade: Seb, John Beck Since John completed his review of this category, I thought I'd let you check off this category by completing mine. :-) Here are my comments in this area:
usr/src/tools/scripts/bfu.sh ---------------------------- * 616-694: It's really too-bad that we're duplicating this large block of code from SUNWcnetr/postinstall. I don't have any good suggestions for alternatives though. * 622,626: bfu.sh does not define a $BASEDIR, and as such, this upgrade path can't work when bfu'ing an alternate root. I believe you want $rootprefix here instead. * 1962-1983: The indentation here gets in the way of readability between 1964 and 1973. One solution would be to create a "import_dlmgmt_service" function. usr/src/uts/common/os/swapgeneric.c ----------------------------------- * 490: I don't think the /* NOTREACHED */ is needed here, nor in any of the pre-existing blocks below it. no comments for: --------------- usr/src/pkgdefs/SUNWarc/prototype_com usr/src/pkgdefs/SUNWarc/prototype_i386 usr/src/pkgdefs/SUNWarc/prototype_sparc usr/src/pkgdefs/SUNWarcr/prototype_com usr/src/pkgdefs/SUNWarcr/prototype_i386 usr/src/pkgdefs/SUNWarcr/prototype_sparc usr/src/pkgdefs/SUNWckr/prototype_com usr/src/pkgdefs/SUNWckr/prototype_i386 usr/src/pkgdefs/SUNWckr/prototype_sparc usr/src/pkgdefs/SUNWcnetr/postinstall usr/src/pkgdefs/SUNWcnetr/prototype_com usr/src/pkgdefs/SUNWcsd/prototype_com usr/src/pkgdefs/SUNWcsl/prototype_com usr/src/pkgdefs/SUNWcsl/prototype_i386 usr/src/pkgdefs/SUNWcsl/prototype_sparc usr/src/pkgdefs/SUNWcslr/prototype_com usr/src/pkgdefs/SUNWcslr/prototype_i386 usr/src/pkgdefs/SUNWcslr/prototype_sparc usr/src/pkgdefs/SUNWcsr/prototype_com usr/src/pkgdefs/SUNWcsu/prototype_com usr/src/pkgdefs/common_files/i.minorperm_i386 usr/src/pkgdefs/common_files/i.minorperm_sparc usr/src/pkgdefs/etc/exception_list_i386 usr/src/pkgdefs/etc/exception_list_sparc usr/src/tools/abi/etc/ABI_i386.db usr/src/tools/abi/etc/ABI_sparc.db usr/src/tools/abi/etc/exceptions usr/src/Targetdirs
