Cathy Zhou wrote:
> To change dladm autopush to dladm ***-linkprop, I'd like to move some of 
> general linkprop logic from libwladm to libdladm (specifically, 
> linkprop.c), because link properties are no longer wifi specific 
> anymore. For example, the following logic should be general enough: the 
> list of possible values for each property and do_check_prop() function; 
> the default value of specific property; read only property, etc., and 
> maybe the pd_getmod() logic.
> 
> Does this sound reasonable?
> 
> I am also reading the libwladm code. Why the allocation of wldp_t (gbuf) 
> cannot be the internal implementation of the pd_get(), pd_set(), 
> pd_getmod() callback? So that the second argument of these callbacks is 
> not needed?
> 
Oh, forgot one question. For which property, val_cnt can be greater than 1 
in wladm_set_prop()?

Thanks
- Cathy

Reply via email to