> Well. Like I said, I'd like to move some general logic of set/get_linkprop 
 > from libwladm to libdladm. As the part of this work, do_set(get)_prop will 
 > be moved to libdladm too. I found it is very hard to understand why 
 > do_set(get)_prop() takes an gbuf argument.

I am not aware of a good reason.

 > This is not true. which function to call is not dependent on the type of the 
 > link, but the property. For example, "autopush" is a property for all links 
 > so that it might call dladm_gen_set_prop(), and "speed" is a property of 
 > wifi, so that it call wifi_set_prop().

I don't see a problem here.  I'd expect that libdladm would first handle
any "link-wide" generic properties itself.  Any unknown properties would
then be passed on to the library associated with the link type, as they
are today.

-- 
meem

Reply via email to