>> To change dladm autopush to dladm ***-linkprop, I'd like to move some >> of general linkprop logic from libwladm to libdladm (specifically, >> linkprop.c), because link properties are no longer wifi specific >> anymore. For example, the following logic should be general enough: >> the list of possible values for each property and do_check_prop() >> function; the default value of specific property; read only property, >> etc., and maybe the pd_getmod() logic. >> >> Does this sound reasonable? >> >> I am also reading the libwladm code. Why the allocation of wldp_t >> (gbuf) cannot be the internal implementation of the pd_get(), >> pd_set(), pd_getmod() callback? So that the second argument of these >> callbacks is not needed? >> > Oh, forgot one question. For which property, val_cnt can be greater than > 1 in wladm_set_prop()? > [cc to the wifi-dladm alias to get opinion of the libwladm authors.]
I talked to Tony and he told me that we used to allow multiple values to be set for the "speed" property but it is not true anymore. Do we still want to keep this possibility open? If not, the code can be simplified. Thanks - Cathy
