> I forgot to mention that I investigated another option that doesn't require > libdladm to have global knowledge of all properties. It is to make the > current do_set_prop() function to be a libdladm function which can be called > by different libraries. But in my opinion, the current signature of this > function is not correct: > > do_set_prop(int fd, wldp_t *gbuf, prop_desc_t *pdp, > char **prop_val, uint_t val_cnt) > > Which I would think should be > > do_set_prop(prop_desc_t *pdp, char **prop_val, uint_t val_cnt) > > But it seems the gbuf is deep into the libwladm's implementation which needs > significant change of the whole libwladm. > > I am fine to work on it. But is there any better option?
I think this is the right approach. -- meem
