> http://cr.opensolaris.org/~yun/webrev_dlmgmtd/
Looks good; some nits.
dladm.c:
* 5503: Seems like "/etc/dladm/datalink.conf" should just be in the
format string itself.
dlmgmt_db.c:
* 374, 378: This appears to be an unrelated bugfix.
dlmgmt_main.c:
* 101, 233: Comment exposes implementation -- would prefer to
refer to the macro name so that it won't get stale if the macro
value gets updated. (Also, why do we have dlmgmt_door_file[]
when it's just DLMGMT_DOOR?)
* 103: Why specify O_EXCL but ignore EEXIST? O_CREAT|O_RDONLY
seems more intuitive to me.
* 103: Why S_IWRITE? (And I think S_IRUSR is the more
standardized form of S_IREAD.)
* 225: Extra trailing ";"
* 249: s/the root privileges/root privilege/ -- but "root" isn't a
privilege. What privilege is actually needed?
* 259: The old code provided a helpful error message when dlmgmtd
was run with insufficient privileges. Seems like that's gone (?)
dls.h:
* 110: Should have a comment explaining its purpose.
* 111: Add blank line to separate it from upcall commands (and
while you're here, /s/command./commands./
--
meem
