> > > The webrev is updated: > > > > > > http://cr.opensolaris.org/~yun/webrev_dlmgmtd/ > > > > Looks good. Regarding dlmgmt_main.c:103: I think it'd actually be clearer > > to just use "0644". Also, given that libdladm.c also has definitions for > > DLADM_DB_OWNER and DLADM_DB_GROUP, maybe we should put these in a > > shareable header, like sys/param.h? > > > It certainly can be done. Do we need to ARC this though?
I don't think so -- sharing some simple #defines doesn't rise to the level of architecture to me, and the symbols would be private, regardless of their presence in a well-known header (and there are numerous existing private symbols in that header). However, please be careful to ensure that the symbols are not visible in any standards-conforming environment. -- meem
