> http://cr.opensolaris.org/~yun/webrev_dlmgmtd/ > > > * 5503: Seems like "/etc/dladm/datalink.conf" should just be in the > > format string itself. > > I intentionally did that because the indent does not look good this > way. Anyway, I changed as you requested.
I thought that might be the reason. Doesn't look that awful though ;-) > > dlmgmt_main.c: > > > * 103: Why S_IWRITE? (And I think S_IRUSR is the more > > standardized form of S_IREAD.) > > > Apparently, write permission is required in order to do fattach(). I've > changed to > O_CREAT|O_RDWR and S_IRUSR|S_IWUSR. I'm a bit confused by this, as the file was previously packaged 0444 and that worked fine (this brings up a related point: will we need 0444 instead of 0400 to later enable show-link to work as a normal user?). Also, I'm unclear why O_RDWR would be needed instead of O_RDONLY as we never actually write to (or read from) the file. -- meem
