Philip Kirk - Solaris Sustaining wrote:
> Agreed, this looks good, my comments are below.

Thank you.

> A high level comment is that the document dives straight in to talking 
> about datalink interfaces. It would be really nice if we could point 
> readers to the Network Link Names Overview document here:
> 
> http://www.opensolaris.org/os/project/clearview/docs/vnameoverview.pdf
> 
> This is another really good document and with the direction things have 
> gone and are going almost essential reading.

Good point, I've added a link.

> What's meant by generally here, "It generally gives administrators 
> flexibility in how they assign names to network interfaces.".  It sounds 
> like there might be cases where it's not possible or that there are 
> restrictions on naming. This might be a good place to call out the 
> naming restrictions.

I don't know what I meant by "generally".  I've removed it.  I've added a
short blurb on naming restrictions in this section following the first
rename example.

> Maybe instead of specifying 3 main benefits it might be better to just 
> have the main benefits? Calling out 3 main benefits almost leaves me 
> looking for what the other smaller benefits might be.

Good poing.  Done.

> In the paragraph starting, "The next step is to create the VLAN links on 
> top of this aggregation.", s/parallel/parallel/.

I know what you mean. :-)  Fixed.

> In example 2 when you show the cfgadm example it might be nice to  show 
> where PCI8 came from as well.

Agreed.  As soon as prime8 comes back from the lab power outage, I'll work 
on getting some expanded text in this example.

>  >Migrating the zone as required would be impossible, as the name of the 
> network interface is embedded in the zone >configuration
> 
> I agree with Meem here. Is it impossible or just much harder to do? 
> Wouldn't you have to run zonecfg and reconfigure networking or would the 
> whole thing break?

Running zonecfg and tweak files referring to network interface may do the 
trick, and I've changed the text in this section to reflect that.

> In some ways I think it would be worth moving some of the conclusions to 
> earlier in the document but also expanding it to mention that if you 
> just start renaming things without planning then you'll likely break 
> things. It's obvious but I'm sure we've all run some commands only to 
> then realize that we've just created a big problem.

Hmm, let me think of how to address this and I'll let you know what I've done.

Thanks,
-Seb

Reply via email to