sagun shakya wrote:
> Cathy Zhou wrote:
>> External webrev:
>>
>>      http://cr.grommit.com/~yun/webrev_uv_09_28
>>
> Hi Cathy,
> 
> Except for the one below I don't have any additional comments since they 
> have been addressed in the preliminary round of review.
> 
> *usr/src/lib/libdlpi/common/libdlpi.c*
> 92: I know the flags argument in dlpi_walk() has been removed due to my 
> question in the last round of review. But since dlpi_walk() is a public 
> interface and we know the 'flags' argument will be added eventually for 
> IP observability. We should just keep it there even though it will not 
> be used by UV?
> 
Sure. I will definitely add it back if UV is putback after IPO.

Thanks
- Cathy


Reply via email to