> > No. in the success case, it should also calls dladm_destroy_conf(conf) and
> > continue.
>
> The lines are:
>
> 506
> 507 status = dladm_write_conf(conf);
> 508 if (status != DLADM_STATUS_OK)
> 509 goto destroyconf;
> 510
> 511 destroyconf:
> 512 dladm_destroy_conf(conf);
> 513 if (status != DLADM_STATUS_OK) {
> 514 if (orig_portstr != NULL)
> 515 free(orig_portstr);
> 516 return (status);
> 517 }
>
> Lines 508-508 look redundant.
On a vaguely related note: Cathy, could you please remove the checks for
NULL prior to the free()? free() can always handle a NULL pointer, so
the checks are just cluttering the code.
--
meem
