Cathy,
Some comments on the devname component of your project changes:
dev_netops.c:
You might want to add this assert following line 163, as if
this is not the case, the code will be doing a VN_RELE at failed.
error = sdev_mknode(ddv, nm, &dv, ...
if (error != 0) {
ASSERT(dv == NULL);
....
In devnet_lookup(), would it make more sense to declare private
as a dls_channel_t and cast it to void where necessary rather
than the other way around?
line 172: blank
line 174: ths -> this
line 176: udpated -> updated
line 190: if sdev_to_vp() were to return an error, whoops.
(this assumption appears elsewhere, hmmm). ASSERT(error == 0)?
devnet_filldir_datalink(): same suggestion re private
lines 284-305: rather than 'goto done', turn the rebuild
code into a block?
At the conclusion of the rebuild, SDEV_BUILD is cleared.
Do we know for certain that the dls_devnet_need_rebuild()
has now been cleared also? Assert this? Redo the
rebuild?
line 332: hold -> held
sdev_subr.c
sdev_vnops.c:
no comments
sdev_impl.h:
sdev_private: turn this into a union with per-directory flavors
rather than just leaving this as a void * catch-all?
SDEV_UPDATE: the name of this symbol is rather generic. make it
more specific and reverse the sense like perhaps SDEV_ATTR_INVALID
242: added an extra unnecessary line
Overall, looks like a straight-forward addition to the dev filesystem.
-jg
