> >> usr/src/lib/libdladm/common/libdlwlan_impl.h - val_desc_t is really a > >> general purpose structure that is shared > >> with linkprop.c (and possibly other files that will be added in > >> the future), and not specific to wlan.; not clear why this is > >> not defined in libdladm.h instead? > > Do you expect other files other than libdladm to use it. If not, I'd like > > move it to libdladm_impl.h instead of libdladm.h. > > I don't expect other files than (the ones internal to) libdladm to use it, so > either one is fine,
libdladm.h should only contain exported APIs, so libdladm_impl.h seems the only appropriate location. -- meem
