Thanks Seb , I've updated the documents as per the comments. Please let me know if you have any comments.
-Thanks Sagun PSARC fasttrack proposal: http://www.opensolaris.org/os/project/clearview/libdlpi/ -Sagun Sebastien Roy wrote: > A few comments: > > * the interface classification for the new functions needs to be made > explicit. > > * I think some background is needed about what the types in > <net/if_types.h> and <netinet/arp.h> are, what they're used for, and why > one might want to translate a DLPI MAC-type to one of these types > using these functions. I'm specifically concerned about why we need > dlpi_iftype(), since I don't think anything except for the Solaris > kernel uses types from <net/if_types.h>... I could be wrong, so some > clarification would be nice. > > * I'm curious why we think that dlpi_iftype() will be more useful than > a function that does the reverse if we have no consumers for the > interface to begin with. What is the justification for this function, > and how do we not have the same justification for its reverse > function? For dlpi_arptype(), it's more obvious since there's a > consumer.
