Cathy,

I missed the deadline, but did manage to review it today, and the changes look 
good.

Just one minor comment: in dladm.c ls_{parseable, persist, header} have been
changed from boolean to bits in a uint32_t. For the sake of clarity, could we 
have
a 
   ls_pad_to_32:29;
please? This seems to be the convention followed elsewhere (e.g., 
tcp_pad_to_bit_31)
and it helps keep the accounting straight if more bits are added there.

--Sowmini
--
This message posted from opensolaris.org

Reply via email to