Hi Cathy,
I just have a few minor comments:
libdladm.h:
33: s/configurein/configure
37: why is stdio.h added? this file doesn't seem to need it.
libdlaggr.h:
58-74:
maybe it's better to rename the structure fields
from lp_xxx to pa_xxx and lg_xxx to ga_xxx to be
consistent with the new structure names
55,59:
it's better to get rid of the +1
libdllink.c:
the walker code for mac and link seems to be
very similar except for the strcmp("aggr",...).
can the code be refactored?
if you are deleting this for clearview anyway, it's ok to leave
it alone.
(btw, line 309 has a memory leak, I forgot the bugid for this)
libdlaggr.c:
speaking of refactoring, aggr's db manipulation code can be
simplified if it's changed to use the i_dladm_rw_db() interface.
again, if you'll be changing this anyway, this can be done later.
eric
--
This message posted from opensolaris.org
