Thanks Eric. See my reply inline.
> I just have a few minor comments:
>
> libdladm.h:
> 33: s/configurein/configure
>
Changed.
> 37: why is stdio.h added? this file doesn't seem to need it.
>
Removed.
> libdlaggr.h:
> 58-74:
> maybe it's better to rename the structure fields
> from lp_xxx to pa_xxx and lg_xxx to ga_xxx to be
> consistent with the new structure names
>
I thought about it but then decided to leave it as is as it is only comestic
change and the change will make the review difficult.
> 55,59:
> it's better to get rid of the +1
>
As this is a bug not related to this change, and it also needs changes in
aggr.h (the definition of laioc_port_t). I'd rather to fix it separately. I
already filed 6535719 to track this. (Actually it is aleady fixed in the
vanity naming changes as it is changed to the link name size).
> libdllink.c:
> the walker code for mac and link seems to be
> very similar except for the strcmp("aggr",...).
> can the code be refactored?
> if you are deleting this for clearview anyway, it's ok to leave
> it alone.
Yes, these codes are significantly changed by Clearview.
> (btw, line 309 has a memory leak, I forgot the bugid for this)
>
It is bug 6454340. I've fixed it and please have a look of the updated
webrev, which I will send out soon.
> libdlaggr.c:
> speaking of refactoring, aggr's db manipulation code can be
> simplified if it's changed to use the i_dladm_rw_db() interface.
> again, if you'll be changing this anyway, this can be done later.
>
Yes, this will be changed by Clearview.
Thanks
- Cathy
