Thank you for your comments. As per the comments I've made the changes and libdlpi.c is down to 1400 lines but the increase is due to additional functions.
Additional changes made were: *A table with the DLPI primitive and maximum buffer size and a helper function dlpi_getprimsize() has been provided to make the code simpler. * Added a table for DLPI/ private MAC type and its description. *Adding the flag DLPI_NOATTACH allows i_dlpi_detach() to be removed. Thanks you for your comments. New webrev information: The webrev against the clearview gate is at: http://zhadum.east.sun.com/export/build1/ws/sshakya/clearview-libdlpi-cr2-changes/webrev_clearviewgate/ Against the last round of code review: http://zhadum.east.sun.com/export/build1/ws/sshakya/clearview-libdlpi-cr2-changes/webrev1/ The workspace and cscope database is at: /net/zhadum.east/export/build1/ws/sshakya/clearview-libdlpi-cr2-changes/usr/src/ Peter Memishian wrote: > * I'm not sure why dli_passive and dli_raw are stored in separate > fields. The code would be simpler if you had a dli_oflags field > that was assigned to `flags' at open time. > > These flags have been moved as bitfields that get set at dlpi_open(). -thanks, Sagun
