Hi Team, [This still is an onging internal review. Once all the internal review comments are addressed, a request for external review will be sent out.]
I have created a new workspace that reflects the comments made by Seb and Dan. Along with that some other changes have also been made to reflect comments I got from Meem; I've included a summary of those comments. Please see separate email for replys to Seb and Dan's comments. webrev: /net/zhadum.east/export/build1/ws/sshakya/clearview-libdlpi-cr-changes/webrev reflects changes made after the codereview comments received from Seb and Dan. /net/zhadum/export/build1/ws/sshakya/clearview-libdlpi-cr-changes/webrev reflects change to the clearview gate. The workspace is at: /net/zhadum.east/export/build1/ws/sshakya/clearview-libdlpi-cr-changes/webrev cscope database are at: /net/zhadum.east/export/build1/ws/sshakya/clearview-libdlpi-cr-changes/usr/src Summary of comments from Meem: usr/src/lib/libdlpi/common/libdlpi_impl.h * prefix internal libdlpi handles with unique name, make cscope lookup simpler. (eg. fd vs dli_fd). usr/src/cmd/cmd-inet/usr.sbin/snoop/snoop_capture.c * line 196: char *linkname to char linknm[DLPI_LINKNAME_MAX]; * line 202: one single call to dlpi_bind() and moved bind semantics to dlpi_bind(). * add ifname to pr_err(). usr/src/cmd/dladm/dladm.c * line 840, 862,1582,1809 1834 instead of typecasting int to an uint_t, changed variables "instance" and "index" to be an uint_t. usr/src/lib/libdlpi/common/libdlpi.c * inline init_hdl() and removed init_hdl(). * added DLPI_SYNC to handle special case for sync. serial line * dlpi_send: sematics for raw mode (thank you Cathy and Huafeng for pointing this bug in dlpi_send. -Sagun
