Hi team,

I would like to request an internal code review for the libdlpi changes.

Here is the link to the webrev of the changes made to libdlpi and the
applications that are being ported.

http://zhadum.east/export/build1/ws/sshakya/clearview-libdlpi-new/webrev/

The workspace is at:
/net/zhadum.east/export/build1/ws/sshakya/clearview-libdlpi-new

How the changes have been tested so far:
*used the bits to punchin
*tested with gldv3 testsuite.
  The summary of test is at
   file:///home/ss150715/tmp/gldv3-test-status
* ran iscsi test-suite for the iscsi changes

*syncinit.c/syncstat.c/syncloop.c are not working as it should so I will
send an update when that is fixed.
*'dladm show-link' is not working.

What is different than the proposal:

* DLPI_ENOLINK is not returned in dlpi_open(), I had planned to return
his error code when opening of device failed but i_dlpi_open() returns
DL_SYSERR instead with the current code. The reason for this is opening
of a link could fail for more than just the link not existing. like EPERM.

I have to file a RFE that will act as a blanket rfe for all these changes.

-Thanks,

Sagun






Reply via email to