On Tue, 2009-08-04 at 17:01 -0400, Rishi Srivatsavai wrote: > Hello Seb, > > My review comments for simnet.c changes: > > 468, 497 (peer ref), 540: ref on dev should be released.
ACCEPT, good catch. > I am wondering if it is better to update simnet_dev_lookup > instead and compare zoneid there. The code at 468, 497, 540 & 613 > can be removed and the lookup function can do the zoneid checks. For simnet_ioc_info(), it's a bit trickier. It's not a simple zoneid comparison. Links that have been assigned to a non-global zone are visible from both the global zone and the non-global zone to which it's assigned. dls_devnet_islinkvisible() does this check for us. Thanks, -Seb
