I've looked at uts/common/inet except the iptun* files.
ip.h:
You can remove the definition of TUN_CMD; I don't think it is used any more.
ip.c: Shouldn't be bump InDelivers when we call connp->conn_recv to send
to iptun?
ip6.c: Ditto.
ip6_if.c: OK
ip_ftable.c: OK
ip_if.c: OK
ip_ire.c: OK
ip_multi.c: OK
ip_ndp.c: You've removed the special handling if IP_ADDR_LEN around line
3682. With this change how does a point-to-multipoint device driver tell
the nexthop that the packet should be sent to? Perhaps 6to4 tunnels
don't need this because the nexthop is always extracted from the IPv6
destination address. But I don't see how other point-to-multipoint
devices (IP over X.25, Fibrechannel, etc) can work with this removed.
ipclassifier.c:
The new ipcl_iptun_classify functions do not check tsol_receive_local().
Should they? Currently in onnv-gate we do check since the tunnel fanout
happens through ip_fanout_proto which continues looking for a matching
conn_t if tsol_receive_local fails.
(Is this what "XXX KEBE ASKS - What about TX and labels?" is asking about?)
ip_srcid.c: OK
ipmp.c: OK
sadb.c: OK
spd.c: Typo at
5862 * NOTE: Even if our policy is trasnport mode, set the
At L5933 what prevents inner_ipv* from pointing past b_wptr? The reason
I'm asking is that you have removed the asserts that checked for this.
spdsock.c: OK
ip_if.h: OK
ip_stack.h: OK
ipclassifier.h: OK
ipsec_impl.h: OK
Erik
