> > > > DM-3 Early on, until T3/E3 Several things here seem like they > > should be > > line 92-ish. defined in iptun.h or iptun_impl.h. Is > > there a reason they aren't? > > REJECT: iptun_impl.h only contains symbols used by multiple source files > in the iptun module. Symbols that are only used in iptun.c are defined > in iptun.c.
That's not usually the criteria for putting something in an *_impl.h file. I'd expect to see all structures and #defines that would be useful to e.g. implementors of mdb dcmds to be present. -- meem
