On Thu, 11 Aug 2022 05:21:48 GMT, Tejesh R <[email protected]> wrote: > The Document for _DefaultStyledDocument.setCharacterAttribute_ states that > the range of length accepted is `length - the length >= 0`, whereas in code > the length check is done only for `length==0`. Meaning the control just > returns if the `length` is 0. Since length is _int_ type and there is a > possibility of negative length being set through the method, the code doesn't > actually handles the negative length case. Hence to handle negative length, > negative length check has been added along with 0 check. Its safe to check > and return the control for `negative` length input. Test case to check the > same is added.
test/jdk/javax/swing/JTextPane/DefaultStyledDocumentTest.java line 1: > 1: /* Guess it can be moved to test/jdk/javax/swing/text/DefaultStyledDocument/ Also, rename it something like TestDocNegLenCharAttr or something similar. ------------- PR: https://git.openjdk.org/jdk/pull/9830
