> The Document for _DefaultStyledDocument.setCharacterAttribute_ states that > the range of length accepted is `length - the length >= 0`, whereas in code > the length check is done only for `length==0`. Meaning the control just > returns if the `length` is 0. Since length is _int_ type and there is a > possibility of negative length being set through the method, the code doesn't > actually handles the negative length case. Hence to handle negative length, > negative length check has been added along with 0 check. Its safe to check > and return the control for `negative` length input. Test case to check the > same is added.
Tejesh R has updated the pull request incrementally with one additional commit since the last revision: Updated based on review comments ------------- Changes: - all: https://git.openjdk.org/jdk/pull/9830/files - new: https://git.openjdk.org/jdk/pull/9830/files/3cbc7c51..e812f009 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=9830&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9830&range=02-03 Stats: 3 lines in 2 files changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/9830.diff Fetch: git fetch https://git.openjdk.org/jdk pull/9830/head:pull/9830 PR: https://git.openjdk.org/jdk/pull/9830
