On Fri, 2 Dec 2022 23:52:55 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:

>> Set the text caret to be visible but not blinking on the non-editable text 
>> area.
>
> Alexander Zuev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Handling the case when blink rate is set while component is unedited
>   Test HidingSelectionTest.java is rewritten and corrected.

I added the setBlinkRate handling when component is unedited so the new rate is 
preserved.

Also setting blink rate to a negative value causes InvalidArgumentException 
because it is checked further down the line in javax.swing.Timer.checkDelay() 
method so it is a non-issue.

Finally the HidingSelectionTest had to be re-written because its logic is 
incorrect and it passes on MacOS and Windows only because of the flaw in the 
test that allows false positive.

-------------

PR: https://git.openjdk.org/jdk/pull/11408

Reply via email to