On Tue, 16 May 2023 06:40:20 GMT, Tejesh R <t...@openjdk.org> wrote: > This is a regression from fix > [JDK-8281966](https://bugs.openjdk.org/browse/JDK-8281966): Absolute path of > symlink is null in JFileChooser. The fix checks whether the file path is a > symbolic link using `Files.isSymbolicLink()` method with path as input. In > windows for specific folders like "This PC"/"Network"/"Libraries" the path > value will be a hex values which causes InvalidPathException. In order to > resolve the issue, since no other checks are available to validate the path > of these folders, checking if the file is link firstly and then for symbolic > link resolves the problem (since File.isLink() doesn't take path as input > rather file is a parameter). Since every symbolic link is a link, this fix > seems logical to me. > The fix is tested in CI for regression and is green. The regression fix is > also tested for confirmation and works fine.
test/jdk/javax/swing/JFileChooser/FileChooserIPETest.java line 80: > 78: frame.add(jfc, BorderLayout.CENTER); > 79: frame.pack(); > 80: frame.setVisible(true); Do we need to dispose the frame? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13998#discussion_r1195890917
