On Wed, 17 May 2023 16:14:43 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

>> Means you are pointing towards `new Runnable()` within Swing worker thread ? 
>> Or you are asking whether `initialize()` has to be in worker thread?
>
> I technically had 2 questions in the last comment.
> 1. Can't you just put the contents of `initialize()` in place of line 53? 
> It's the only thing being run.
> 2. Why are we creating a `Runnable` instance instead of just calling 
> `initialize` in main?
> 
> And I have another completely separate comment. If you actually need this to 
> be a `Runnable`, I think you can replace this with a lambda function.

Point 1 can be done, nothing specific to adding everything into a function. 
Just that we are trying to maintain uniformity across other test. Point 2, it 
can be either with Runnable/direct lambda function, just that no return type is 
there we can use Runnable too I just choose it, nothing specific to 
functionlity.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13998#discussion_r1196783713

Reply via email to