On Wed, 17 May 2023 04:20:23 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Updated based on review comments
>
> test/jdk/javax/swing/JFileChooser/FileChooserIPETest.java line 41:
>
>> 39: * @build PassFailJFrame
>> 40: * @summary Test to check if the certain windows like "This PC",
>> 41: * "Library","network" does not throw Invalid Path Exception on
>> selection.
>
> Space after "," and capital "N" to maintain consistency
Updated.
> test/jdk/javax/swing/JFileChooser/FileChooserIPETest.java line 54:
>
>> 52: public void run() {
>> 53: initialize();
>> 54: }
>
> Does this need to be a "Runnable"? Can't initialize()'s contents just be put
> into main? I might be missing something
Means you are pointing towards `new Runnable()` within Swing worker thread ? Or
you are asking whether `initialize()` has to be in worker thread?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13998#discussion_r1195953039
PR Review Comment: https://git.openjdk.org/jdk/pull/13998#discussion_r1195954270
