Re: RFR: 8140527: JInternalFrame has incorrect title button width [v5]

[Andrey Turbanov]

On Mon, 26 Jun 2023 11:52:34 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> Title buttons under Widows Classic L&F got their sizes from the XP desktop 
>> theme in which button width can be bigger than height. It is construed as XP 
>> bug where sizes aren't updated properly so it uses height units for width 
>> for XP and later windows. The proposed fix uses the [same 
>> technique](https://github.com/openjdk/jdk/blob/a0595761ef35c4eec8cb84326a869b9473cd5bba/src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsInternalFrameTitlePane.java#L78-L82)
>>  for Classic and forces title buttons to be square and to fit the frame 
>> title in height.
>> 
>> Before fix SwingSet2 demo (Windows Classic InternalFrame)
>> ![image](https://github.com/openjdk/jdk/assets/43534309/3d6ec539-5e17-46ce-aba5-e724af6085fe)
>> 
>> After fix
>> ![image](https://github.com/openjdk/jdk/assets/43534309/db0135e4-d7f3-41a4-bbfa-e8e95cbd071d)
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Formatting

test/jdk/javax/swing/JInternalFrame/InternalFrameTitleButtonTest.java line 53:

> 51:     public static void main(String[] args) throws Exception {
> 52:         String osName = System.getProperty("os.name");
> 53:         if(!osName.toLowerCase().contains("win")) {

Suggestion:

        if (!osName.toLowerCase().contains("win")) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14555#discussion_r1242763596