On Mon, 26 Jun 2023 21:29:18 GMT, Alexey Ivanov <[email protected]> wrote:
>> @prsadhuk The string compare can be replaced with `OSInfo.getOSType() == >> OSInfo.OSType.WINDOWS` and in case you want to retain the OSCheck along >> with `@requires (os.family == "windows")` when run as standalone test. > > I think [it's > redundant](https://github.com/openjdk/jdk/pull/14555#discussion_r1242206200) > in this case because setting Windows Classic L&F will throw an exception on > other platforms. > > It was [`OSInfo`-check > initially](https://github.com/openjdk/jdk/pull/14555#discussion_r1240155464). > > I'm fine with either way. However, I prefer *no check* in this particular > case. Actually I will prefer gentle nudge stating it's not applicable other than windows as compared to harsh failing via throwing exception, if you dont mind.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/14555#discussion_r1243174370
