On Mon, 26 Jun 2023 21:00:30 GMT, Andrey Turbanov <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Formatting
>
> test/jdk/javax/swing/JInternalFrame/InternalFrameTitleButtonTest.java line 53:
>
>> 51: public static void main(String[] args) throws Exception {
>> 52: String osName = System.getProperty("os.name");
>> 53: if(!osName.toLowerCase().contains("win")) {
>
> Suggestion:
>
> if (!osName.toLowerCase().contains("win")) {
@prsadhuk The string compare can be replaced with `OSInfo.getOSType() ==
OSInfo.OSType.WINDOWS` and in case you want to retain the OSCheck along with
`@requires (os.family == "windows")` when run as standalone test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14555#discussion_r1242783152
