On Mon, 14 Aug 2023 03:31:37 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
> Disabled JPasswordField foreground color was not grayed out in GTK LAF. > > The foreground color in disabled state was close to black color (RGB 0,0,0) > for password field which is not differentiable from enabled state foreground > color. > > To fix for this problem, the widget type is changed to `TEXT_AREA `for > disable password field which returns the foreground color as gray. Checked > with Oracle linux as well and fix worked fine. > > An automated test case has been added and checked in CI, link is added in > JBS. Test mentioned in JBS also works fine with the fix. Same observation holds for JTextField and hope other remaining two (SPINNER_TEXT_FIELD and FORMATTED_TEXT_FIELD) also, consolidating and finding a fix which applies to all four (TEXT_FIELD, PASSWORD_FIELD, SPINNER_TEXT_FIELD and FORMATTED_TEXT_FIELD) might be optimal. ------------- PR Review: https://git.openjdk.org/jdk/pull/15263#pullrequestreview-1581799618