On Fri, 1 Sep 2023 04:17:04 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix extended for TextField, FormattedTextField, Spinner
>
> src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c line 2413:
>
>> 2411: && state_type == GTK_STATE_INSENSITIVE && color_type ==
>> TEXT_FOREGROUND) {
>> 2412: widget_type = TEXT_AREA;
>> 2413: }
>
> I guess l2403 has same checks which can be clubbed together
>
> if (widget_type == TEXT_FIELD || widget_type == PASSWORD_FIELD
> || widget_type == SPINNER_TEXT_FIELD || widget_type ==
> FORMATTED_TEXT_FIELD) {
> if (state_type == GTK_STATE_SELECTED && color_type ==
> TEXT_BACKGROUND}
> || state_type == GTK_STATE_INSENSITIVE && color_type ==
> TEXT_FOREGROUND) {
> widget_type = TEXT_AREA;
> }
> }
>
>
> What do you think?
I think it's better to clubbed them, updated as per suggestion.
> test/jdk/javax/swing/JPasswordField/TestDisabledPasswordFieldForegroundColor.java
> line 67:
>
>> 65: boolean testFail = false;
>> 66: robot = new Robot();
>> 67: robot.setAutoDelay(1000);
>
> autoDelay normally is 100ms
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15263#discussion_r1312697730
PR Review Comment: https://git.openjdk.org/jdk/pull/15263#discussion_r1312697914
