On Fri, 18 Aug 2023 18:03:54 GMT, Damon Nguyen <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix extended for TextField, FormattedTextField, Spinner
>
> src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c line 2409:
>
>> 2407: && color_type == FOREGROUND) {
>> 2408: widget_type = MENU;
>> 2409: } else if (widget_type == PASSWORD_FIELD && state_type ==
>> GTK_STATE_INSENSITIVE
>
> Looks like this line and a few others nearby exceed the character limit per
> line if you wanted to correct that as well.
Updated the character limit for the current fix. I think other lines can be
done later.
> test/jdk/javax/swing/JPasswordField/TestDisabledPasswordFieldForegroundColor.java
> line 58:
>
>> 56: SwingUtilities.invokeAndWait(() -> {
>> 57: createAndShowUI();
>> 58: });
>
> Suggestion:
>
>
> SwingUtilities.invokeAndWait(TestDisabledPasswordFieldForegroundColor::createAndShowUI);
>
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15263#discussion_r1299939026
PR Review Comment: https://git.openjdk.org/jdk/pull/15263#discussion_r1299936328
