On Tue, 30 Jan 2024 09:17:46 GMT, Renjith Kannath Pariyangad
<[email protected]> wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know your suggestions.
>>
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Capitalized static final variables
test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 142:
> 140: } catch (NullPointerException e) {
> 141: g.drawString("caught expected NPE for null String, int",
> 20, 40);
> 142: }/* catch (Exception e) {
I guess u can remove these instead of commenting? Any reason for commenting
these instead of removing?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1472528908
