On Tue, 30 Jan 2024 09:17:46 GMT, Renjith Kannath Pariyangad
<[email protected]> wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know your suggestions.
>>
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Capitalized static final variables
test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 38:
> 36: * @bug 4956397
> 37: * @key printer
> 38: * @library /java/awt/regtesthelpers
library lines on same line
test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 63:
> 61:
> 62: new PageDlgPrnButton() ;
> 63: passFailJFrame.awaitAndCheck();
simplifiable with
PassFailJFrame.builder()
.instructions(INSTRUCTIONS)
.rows((int) INSTRUCTIONS.lines().count() + 1)
.columns(45)
.build()
.awaitAndCheck();
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473513477
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1473517506
