Re: RFR: 8324808 : Manual printer tests have no Pass/Fail buttons, instructions close set 3 [v2]

[Alexey Ivanov]

On Wed, 31 Jan 2024 21:58:24 GMT, Alisen Chung <ach...@openjdk.org> wrote:

>> Renjith Kannath Pariyangad has updated the pull request incrementally with 
>> one additional commit since the last revision:
>> 
>>   Capitalized static final variables
>
> test/jdk/java/awt/print/PrinterJob/PageDlgPrnButton.java line 63:
> 
>> 61: 
>> 62:         new PageDlgPrnButton() ;
>> 63:         passFailJFrame.awaitAndCheck();
> 
> simplifiable with 
> 
> PassFailJFrame.builder()
>                 .instructions(INSTRUCTIONS)
>                 .rows((int) INSTRUCTIONS.lines().count() + 1)
>                 .columns(45)
>                 .build()
>                 .awaitAndCheck();

Could you elaborate how it could be simplified? I can't see it.

> test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 126:
> 
>> 124: 
>> 125:             Graphics2D g2d = (Graphics2D) g;
>> 126:             g2d.translate(pgFmt.getImageableX(), pgFmt.getImageableY());
> 
> dispose g2D object

Do not dispose of the `Graphics` object that is passed as a parameter to 
`paint` or `print`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1483150668
PR Review Comment: https://git.openjdk.org/jdk/pull/17609#discussion_r1483263329