On Wed, 13 Mar 2024 17:20:38 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Following InputMethod applet tests are converted to main using PassFailJFrame >> >> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java) >> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) >> >> - test instructions are updated to make to more clear >> - tests renamed >> - moved one directory above - /java/awt/im/ >> - html file deleted. >> >> Two tests are updated as part of this PR as they are similar, details here >> https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598 > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > instruction updated Marked as reviewed by azvegint (Reviewer). test/jdk/java/awt/im/PinyinIMFullstopTest.java line 81: > 79: private static JComponent createUI() { > 80: JPanel panel = new JPanel(); > 81: JTextField input = new JTextField(20); Is there a specific reason why we switched from a text area to a text field? ------------- PR Review: https://git.openjdk.org/jdk/pull/18251#pullrequestreview-1934832780 PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1523682463
