On Sat, 16 Mar 2024 22:35:16 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Following InputMethod applet tests are converted to main using PassFailJFrame >> >> 1. java/awt/im/8132503/bug8132503.java (Renamed to PinyinIMFullstopTest.java) >> 2. java/awt/im/8148984/bug8148984.java (Renamed to PinyinIMCommaTest.java) >> >> - test instructions are updated to make to more clear >> - tests renamed >> - moved one directory above - /java/awt/im/ >> - html file deleted. >> >> Two tests are updated as part of this PR as they are similar, details here >> https://github.com/openjdk/jdk/pull/18251#issuecomment-1992577598 > > Harshitha Onkar has updated the pull request incrementally with one > additional commit since the last revision: > > review updates test/jdk/java/awt/im/PinyinIMCommaTest.java line 67: > 65: if (OSInfo.getOSType() != OSInfo.OSType.MACOSX) { > 66: throw new SkippedException("This test is for macOS only"); > 67: } Is it required to have this SkippedException? I guess this test already have jtreg tag @requires("mac") and the test needs to be run with jtreg since we are using PassFailJFrame so I think it's redundant to have this check again in test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1527956025
