On Thu, 14 Mar 2024 04:43:48 GMT, Tejesh R <t...@openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   instruction updated
>
> test/jdk/java/awt/im/PinyinIMCommaTest.java line 44:
> 
>> 42: 
>> 43: public class PinyinIMCommaTest {
>> 44:     private static final String INSTRUCTIONS = """
> 
> `INSTRUCTIONS ` can be moved inside main  (Other test also)

Since it is okay to have it either as static var or within main, I'm going to 
leave it as it is now.

> test/jdk/java/awt/im/PinyinIMCommaTest.java line 82:
> 
>> 80:         JTextField input = new JTextField(20);
>> 81:         panel.add(new JLabel("Text field:"));
>> 82:         panel.add(input);
> 
> can add JTextField also this way `panel.add(new JTextField(20));`?

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1526685355
PR Review Comment: https://git.openjdk.org/jdk/pull/18251#discussion_r1526685550

Reply via email to