On Mon, 18 Mar 2024 09:37:23 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> > > > > I am not sure but to me the images dont seem to match in > > > > > windows11..it seems JEditorPane image is 1 pixel thicker than golden > > > > > images...in which case, it needs to be problemlisted Also, I guess > > > > > this has potential of making it automated by loading the golden > > > > > images and JEditorPane in BufferedImage and then compare... > > > > >  > > > > > > > > > > > > You mean to say the border of JEditorPane is 1 pixel thicker ? > > > > > > > > > it doesn't look exactly same subjectively... > > >  > > > > > > Yeah, but in instructions they say it should look similar, so wasn't sure > > whether to problem list or proceed with conversion. You think we should > > problem list? > > I am not sure...I think there was some fix regarding border stroke sometime > back either by @honkar-jdk or @DamonGuy . Maybe expectation should be > somewhat different now in which case, probably the instructions should be > amended accordingly...Let them verify once.. or maybe run the test with uiScale 1.0 as I believe the golden images are generated without any scaling and windows has default 1.25/1.5 scaling ------------- PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2003905130
