On Mon, 18 Mar 2024 13:27:56 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>>> > > > I am not sure but to me the images dont seem to match in >>> > > > windows11..it seems JEditorPane image is 1 pixel thicker than golden >>> > > > images...in which case, it needs to be problemlisted Also, I guess >>> > > > this has potential of making it automated by loading the golden >>> > > > images and JEditorPane in BufferedImage and then compare... >>> > > >  >>> > > >>> > > >>> > > You mean to say the border of JEditorPane is 1 pixel thicker ? >>> > >>> > >>> > it doesn't look exactly same subjectively... >>> >  >>> >>> Yeah, but in instructions they say it should look similar, so wasn't sure >>> whether to problem list or proceed with conversion. You think we should >>> problem list? >> >> I am not sure...I think there was some fix regarding border stroke sometime >> back either by @honkar-jdk or @DamonGuy . Maybe expectation should be >> somewhat different now in which case... > >> > > > > I am not sure but to me the images dont seem to match in >> > > > > windows11..it seems JEditorPane image is 1 pixel thicker than golden >> > > > > images...in which case, it needs to be problemlisted Also, I guess >> > > > > this has potential of making it automated by loading the golden >> > > > > images and JEditorPane in BufferedImage and then compare... >> > > > >  >> > > > >> > > > >> > > > You mean to say the border of JEditorPane is 1 pixel thicker ? >> > > >> > > >> > > it doesn't look exactly same subjectively... >> > >  >> > >> > >> > Yeah, but in instructions they say it should look similar, so wasn't sure >> > whether to problem list or proceed with conversion. You think we should >> > problem list? >> >> I am not sure...I think there was some fix regarding border stroke sometime >> back either by @honkar-jdk or @DamonGuy . Maybe expectation should be >> somewhat different n... > @prsadhuk With scaling 1.0 it'll appear this way. I think it's supposed to be > 1.0 scaling and its looking similar now. >  I am not sure..it still seems 1.25 bigger than golden image..."similar" word has different connotation and is very subjective....is it intentional that "same" was not mentioned? What if we say, Earth and Mars are similar as they are planets... ------------- PR Comment: https://git.openjdk.org/jdk/pull/18260#issuecomment-2004016674
