On Mon, 18 Mar 2024 07:45:42 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework.
>
> Tested in macOS where it didn't worked for "key press C to change tab layout"
> else it worked for other "key press (R, B, L, T) to change tab position. So,
> test is still in problem list.
LGTM, minor changes added inline.
test/jdk/javax/swing/JTabbedPane/bug4666224.java line 48:
> 46:
> 47: public class bug4666224 {
> 48: final static int placements[] = { JTabbedPane.LEFT,
> JTabbedPane.RIGHT, JTabbedPane.TOP, JTabbedPane.BOTTOM };
placements isn't used and can be removed.
test/jdk/javax/swing/JTabbedPane/bug4666224.java line 51:
> 49: private static JTabbedPane tabPane;
> 50: private static JFrame frame;
> 51: private static JPanel mainPanel;
mainPanel can be made local
test/jdk/javax/swing/JTabbedPane/bug4666224.java line 58:
> 56: 2. Lose focus on the window by clicking on some other
> window.
> 57: 3. Focus indicator should disappear
> 58: 4. Regain focus on the window by pressing the tab,
The regain focus part also doesn't work on macOS along with change layout.
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/18340#pullrequestreview-1947634902
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531289197
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531293527
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531292885
