On Wed, 20 Mar 2024 08:19:29 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> test/jdk/javax/swing/JTabbedPane/bug4666224.java line 54:
>>
>>> 52: ON ALL PLATFORMS
>>> 53: 1. Click on any of the tabs, focus indicator is
>>> visible.
>>> 54: 2. Lose focus on the window by clicking on some
>>> other window.
>>
>> Lose focus?
>
> Yeah, it means the current focused windows should not be focused.
I was getting confused whether it should be lose or loose in this context?
>> test/jdk/javax/swing/JTabbedPane/bug4666224.java line 132:
>>
>>> 130: map.put("bottom", new RotateAction(JTabbedPane.BOTTOM));
>>> 131: map.put("changeLayout", new ChangeLayoutAction());
>>> 132: map.put("dump", new DumpAction());
>>
>> `DumpAction `can also be mentioned in INSTRUCTIONS I guess, since its been
>> used here.
>
> There is no instruction mentioned in old applet test. Kept it as it is.
I guess you can update it since its there in the test, still not mandatory.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531797814
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531798987
