On Wed, 20 Mar 2024 04:18:46 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> Conversion of manual applet test to main based using PassFailJFrame manual 
>> framework.
>> 
>> Tested in macOS where it didn't worked for "key press C to change tab 
>> layout" else it worked for other "key press (R, B, L, T) to change tab 
>> position. So, test is still in problem list.
>
> Abhishek Kumar has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   minor fix

test/jdk/javax/swing/JTabbedPane/bug4666224.java line 54:

> 52:                 ON ALL PLATFORMS
> 53:                     1. Click on any of the tabs, focus indicator is 
> visible.
> 54:                     2. Lose focus on the window by clicking on some other 
> window.

Lose focus?

test/jdk/javax/swing/JTabbedPane/bug4666224.java line 132:

> 130:         map.put("bottom", new RotateAction(JTabbedPane.BOTTOM));
> 131:         map.put("changeLayout", new ChangeLayoutAction());
> 132:         map.put("dump", new DumpAction());

`DumpAction `can also be mentioned in INSTRUCTIONS I guess, since its been used 
here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531541477
PR Review Comment: https://git.openjdk.org/jdk/pull/18340#discussion_r1531546196

Reply via email to