On Thu, 21 Mar 2024 17:15:31 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> test/jdk/java/awt/image/multiresolution/MultiDisplayTest.java line 62: >> >>> 60: - 2nd display is non-HiDPI. >>> 61: >>> 62: In other cases please simply push "Pass". >> >> These conditions can be detected. On the other hand, since it's a manual >> test, the tester could enable or connect a second monitor, so it makes sense >> to preserve the instructions. > > Do we need an occasional _Skip_ button? Yet adding such a button to throw > `jtreg.SkippedException` will introduce a transitive dependency on the > library which contains the `SkippedException`. I'm OK with either direction. To me, passing the test seems fine for cases we'd skip, but adding a `Skip` button may seem more logical. I was OK with this approach enough to stick with the original instructions. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534353748
