On Thu, 21 Mar 2024 17:40:55 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> I'm OK with either direction. To me, passing the test seems fine for cases >> we'd skip, but adding a `Skip` button may seem more logical. I was OK with >> this approach enough to stick with the original instructions. > > I'm not suggesting modifying the instructions, I'm bringing up it for a > discussion. > > Essentially, `SkippedException` is also like passing the test, it's > indistinguishable in the report. Only the log of the test run will contain > the information that the test was skipped. > > From this point of view, it's wiser not to introduce an additional dependency > which will affect all the manual tests. Makes sense, thanks. The feature would definitely be nice for circumstances like this. This seems to be the first test this sprint for me that the `Skip` button would apply to. So, not sure how often it would come up. Taking into account your point of having an additional dependency on all of these manual tests, maybe better to not have it for now unless similar circumstances pop up more frequently. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18354#discussion_r1534366700
